Copilot commented on code in PR #11560:
URL:
https://github.com/apache/incubator-gluten/pull/11560#discussion_r2762555689
##########
gluten-core/pom.xml:
##########
@@ -184,7 +185,7 @@
<goals>
<goal>run</goal>
</goals>
- <phase>generate-resources</phase>
+ <phase>prepare-package</phase>
Review Comment:
Moving the `build-info` antrun execution to `prepare-package` means
`gluten-build-info.properties` is generated *after* the default
`process-resources` phase. Since this file is written under
`${project.build.directory}/generated-resources` (see
`dev/gluten-build-info.sh`) and resources are only copied into
`${project.build.outputDirectory}` during `process-resources`, the
`gluten-core` artifact (and reactor classpath for downstream modules) will not
contain the build-info resource in a clean build. This can break runtime code
that loads `gluten-build-info.properties` (e.g.,
`shims/common/.../GlutenBuildInfo.scala` throws if missing) and any tests that
touch that code.
Consider either keeping this execution before `process-resources`, or adding
a resources copy step after this execution (e.g., a `maven-resources-plugin`
execution in `prepare-package`) / adjusting the script to write directly into
`${project.build.outputDirectory}` so the file ends up on the classpath before
packaging and downstream module tests.
```suggestion
<phase>generate-resources</phase>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
