FelixYBW commented on code in PR #11606:
URL:
https://github.com/apache/incubator-gluten/pull/11606#discussion_r2796691355
##########
docs/velox-configuration.md:
##########
@@ -48,6 +48,7 @@ nav_order: 16
| spark.gluten.sql.columnar.backend.velox.maxSpillFileSize
| 1GB | The maximum size of a single spill file created
|
| spark.gluten.sql.columnar.backend.velox.maxSpillLevel
| 4 | The max allowed spilling level with zero being the
initial spilling level
|
| spark.gluten.sql.columnar.backend.velox.maxSpillRunRows
| 3M | The maximum row size of a single spill run
|
+| spark.gluten.sql.columnar.backend.velox.maxTargetFileSizeSession
| 0b | The target file size for each output file when
writing data. 0 means no limit on target file size, and the actual file size
will be determined by other factors such as max partition number and shuffle
batch size.
|
Review Comment:
Does it map to iceberg's `write.target-file-size-bytes`? and honor
`spark.sql.iceberg.advisory-partition-size`? If so let's honor this config in
Gluten as well.
If it only take effect on iceberg, we may just reuse iceberg's config
instead of a new config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
