acvictor commented on PR #11609:
URL:
https://github.com/apache/incubator-gluten/pull/11609#issuecomment-3924918700
> > VeloxColumnarToRowExec
> > └── ColumnarCollectLimitExec - op1
> > └── RowToVeloxColumnarExec
>
> @acvictor Thanks for providing the detailed query plan.
`ColumnarCollectLimitExec` is a Scala implementation and might automatically
supports the TimestampNTZ type.
>
> For this patch, to make the `TimestampNTZ` fallback strategy work, I
assume we need to ensure that both `VeloxColumnarToRowExec` and
`RowToVeloxColumnarExec` handle TimestampNTZ correctly. I was a bit surprised
by your test results showing that they seem to work with only a small change in
`toArrowSchem`a. Is this because the type is treated during conversion simply
as an Arrow timestamp without a timezone? Could you help confirm if they work
well? Thanks.
Is this because the type is treated during conversion simply as an Arrow
timestamp without a timezone? - Yes that's right! I was able to get all OSS
Delta tests to pass with this change as well as Spark and Gluten UTs and have
not found any issue so far.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
