acvictor commented on code in PR #9473:
URL: https://github.com/apache/incubator-gluten/pull/9473#discussion_r2835855382
##########
backends-velox/src/main/scala/org/apache/gluten/execution/HashAggregateExecTransformer.scala:
##########
@@ -716,6 +716,46 @@ case class RegularHashAggregateExecTransformer(
ignoreNullKeys
) {
+ override def isOffloadedSortExec: Boolean = false
+
+ override protected def allowFlush: Boolean = false
+
+ override def simpleString(maxFields: Int): String =
+ s"${super.simpleString(maxFields)}"
+
+ override def verboseString(maxFields: Int): String =
+ s"${super.verboseString(maxFields)}"
+
+ override protected def withNewChildInternal(newChild: SparkPlan):
HashAggregateExecTransformer = {
+ copy(child = newChild)
+ }
+}
+
+// Hash aggregation that is offloaded from sort aggregation.
+// Is identical to RegularHashAggregateExecTransformer but with a
+// different value of isOffloadedSortExec.
+case class OffloadedSortHashAggregateExecTransformer(
+ requiredChildDistributionExpressions: Option[Seq[Expression]],
+ groupingExpressions: Seq[NamedExpression],
+ aggregateExpressions: Seq[AggregateExpression],
+ aggregateAttributes: Seq[Attribute],
+ override val initialInputBufferOffset: Int,
+ resultExpressions: Seq[NamedExpression],
+ child: SparkPlan,
+ ignoreNullKeys: Boolean = false)
+ extends HashAggregateExecTransformer(
+ requiredChildDistributionExpressions,
+ groupingExpressions,
+ aggregateExpressions,
+ aggregateAttributes,
+ initialInputBufferOffset,
+ resultExpressions,
+ child,
+ ignoreNullKeys
+ ) {
+
+ override def isOffloadedSortExec: Boolean = true
+
Review Comment:
> Apologize for the relay.
>
> If we have to add a boolean flag, how about directly adding
`SortAggregateExecTransformer`? Then we can decide whether to remove the sort
based on the operator class. It was actually suggested in comment [#9473
(comment)](https://github.com/apache/incubator-gluten/pull/9473#issuecomment-2863912230)
which I haven't seen is addressed. Would you like to help check this? Thanks.
@zhztheplayer sorry for dropping the ball on this. I have updated the PR
based on your comments. Can you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
