jinchengchenghh commented on code in PR #11641:
URL: 
https://github.com/apache/incubator-gluten/pull/11641#discussion_r2846947317


##########
cpp/velox/compute/VeloxBackend.cc:
##########
@@ -317,7 +318,13 @@ void VeloxBackend::initConnector(const 
std::shared_ptr<velox::config::ConfigBase
   }
   velox::connector::registerConnector(
       
std::make_shared<velox::connector::hive::HiveConnector>(kHiveConnectorId, 
hiveConf, ioExecutor_.get()));
-  
+  IcebergConnectorFactory icebergFactory;
+  auto icebergConnector = icebergFactory.newConnector(

Review Comment:
   If the IcebergConnectorFactory is reverted, this PR cannot compile 
successfully CC @PingLiuPing 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to