baibaichen commented on code in PR #11595: URL: https://github.com/apache/incubator-gluten/pull/11595#discussion_r2851009492
########## dev/inc-build-cpp.sh: ########## @@ -0,0 +1,196 @@ +#!/bin/bash + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Incremental C++ build for Gluten + Velox (no source reset, no Maven, no OS setup) +# Usage: ./dev/inc-build-cpp.sh [--build_type=Debug|Release] [--update_vcpkg] + +set -eu + +CURRENT_DIR=$(cd "$(dirname "$BASH_SOURCE")"; pwd) +GLUTEN_DIR="$CURRENT_DIR/.." + +# Helper functions +num_threads() { + [[ -n "${NUM_THREADS:-}" ]] && echo "$NUM_THREADS" && return + if [[ "$(uname)" == "Darwin" ]]; then + local cores=$(sysctl -n hw.physicalcpu) + echo $(( cores > 2 ? cores - 2 : cores )) + else + echo $(nproc --ignore=2) + fi +} + +platform() { + [[ "$(uname -s)" == "Linux" ]] && echo "linux" || echo "darwin" +} + +arch() { + case "$(uname -m)" in + x86_64|amd64) echo "amd64" ;; + *) echo "aarch64" ;; + esac +} + +step() { echo -e "\n[Step $1/4] $2..."; } + +extract_opt() { + grep "^$1:" "$GLUTEN_BUILD_DIR/CMakeCache.txt" 2>/dev/null | \ + cut -d= -f2 || echo "${2:-ON}" +} + +# Defaults +VELOX_HOME="$GLUTEN_DIR/ep/build-velox/build/velox_ep" +UPDATE_VCPKG=OFF +NUM_THREADS=${NUM_THREADS:-$(num_threads)} + +# Parse arguments +for arg in "$@"; do + case $arg in + --build_type=*) BUILD_TYPE="${arg#*=}" ;; + --scala_version=*) SCALA_VERSION="${arg#*=}" ;; + --velox_home=*) VELOX_HOME="${arg#*=}" ;; + --num_threads=*) NUM_THREADS="${arg#*=}" ;; + --update_vcpkg) UPDATE_VCPKG=ON ;; + *) + echo "Unknown: $arg" + echo "Usage: $0 [--build_type=Debug|Release] [--update_vcpkg]" + exit 1 + ;; + esac +done + +# Auto-detect BUILD_TYPE +if [ -z "${BUILD_TYPE:-}" ]; then + [ -d "$VELOX_HOME/_build/debug" ] && BUILD_TYPE=Debug || BUILD_TYPE=Release +fi + +# Auto-detect SCALA_VERSION +if [ -z "${SCALA_VERSION:-}" ]; then + if [ -d "$GLUTEN_DIR/backends-velox/target/scala-2.13" ]; then + SCALA_VERSION=2.13 + else + SCALA_VERSION=2.12 + fi +fi + +# Paths +VELOX_BUILD_DIR_NAME=$([[ "$BUILD_TYPE" =~ ^[Dd]ebug$ ]] && echo 'debug' || echo 'release') +VELOX_BUILD_DIR="$VELOX_HOME/_build/$VELOX_BUILD_DIR_NAME" +GLUTEN_BUILD_DIR="$GLUTEN_DIR/cpp/build" + +# Validate directories +for dir in "$VELOX_HOME" "$VELOX_BUILD_DIR" "$GLUTEN_BUILD_DIR"; do + if [ ! -d "$dir" ]; then + echo "ERROR: Missing $dir" + echo "Run: ./dev/package-vcpkg.sh --build_type=$BUILD_TYPE" + exit 1 + fi +done + +# Validate CMake cache +for cache in "$VELOX_BUILD_DIR/CMakeCache.txt" "$GLUTEN_BUILD_DIR/CMakeCache.txt"; do + if [ ! -f "$cache" ]; then + echo "ERROR: Missing $cache. Run full build first" + exit 1 + fi +done + +echo "============================================" +echo "Gluten C++ Incremental Build" +echo "BUILD_TYPE: $BUILD_TYPE | THREADS: $NUM_THREADS" +echo "============================================" + +cd "$GLUTEN_DIR" + +# Step 1: vcpkg +BUILD_OPTIONS="--build_tests=$(extract_opt BUILD_TESTS)" +BUILD_OPTIONS="$BUILD_OPTIONS --enable_s3=$(extract_opt ENABLE_S3)" +BUILD_OPTIONS="$BUILD_OPTIONS --enable_gcs=$(extract_opt ENABLE_GCS)" +BUILD_OPTIONS="$BUILD_OPTIONS --enable_abfs=$(extract_opt ENABLE_ABFS OFF)" + +if [ "$UPDATE_VCPKG" = "ON" ]; then Review Comment: I use `UPDATE_VCPKG` because if vcpkg.json changes, we need to refresh/update vcpkg dependencies, and that can happen in practice. `RUN_VCPKG_INSTALL` sounds like we always just run an install, which is less accurate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
