baibaichen opened a new pull request, #11684:
URL: https://github.com/apache/incubator-gluten/pull/11684

   ## What changes were proposed in this pull request?
   
   Enable the previously disabled `GlutenParquetTypeWideningSuite` test suite 
(84 tests) for Spark 4.0 and 4.1, which validates Parquet type widening support 
([SPARK-40876](https://issues.apache.org/jira/browse/SPARK-40876)).
   
   ### Changes
   
   1. **Exception translation** (`ClosableIterator.java` + 
`ColumnarBatchOutIterator.java`): Add `translateException()` to convert Velox 
type conversion errors to `SchemaColumnConvertNotSupportedException`, matching 
Spark's expected exception type.
   
   2. **Enable suite** (`VeloxTestSettings.scala` + 
`GlutenParquetTypeWideningSuite.scala` for spark40 and spark41):
      - Enable the suite with 60 excludes (39 truly excluded tests that need 
Velox C++ changes + 21 excluded-then-overridden via `testGluten`)
      - Disable native writer (test read path only)
      - 21 `testGluten` overrides for tests where Velox correctly rejects type 
conversions matching Spark vectorized reader behavior
   
   ### Test Results
   
   | | Spark 4.0 | Spark 4.1 |
   |--|-----------|-----------|
   | ✅ Passed | 45 | 45 |
   | ❌ Excluded | 39 | 39 |
   | **Total** | **84** | **84** |
   
   The 39 excluded tests require Velox C++ changes (type widening support in 
`convertType()`) and will be addressed in follow-up PRs.
   
   Fixes #11683
   
   ## How was this patch tested?
   
   Ran `GlutenParquetTypeWideningSuite` locally for both Spark 4.0 and 4.1, 
achieving 45 pass / 0 fail / 60 ignored (39 truly excluded + 21 overrides that 
pass).
   
   ## Was this patch authored or co-authored using generative AI tooling?
   
   Yes, co-authored with GitHub Copilot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to