FelixYBW commented on PR #11452:
URL:
https://github.com/apache/incubator-gluten/pull/11452#issuecomment-4002119831
Record here, thanks @rui-mo 's confirmation
tryDestrucSafe stack:
```
0# gluten::VeloxMemoryManager::tryDestructSafe() in
1# gluten::VeloxMemoryManager::~VeloxMemoryManager() in
2# gluten::VeloxMemoryManager::~VeloxMemoryManager() in
3# gluten::MemoryManager::release(gluten::MemoryManager*)
4# Java_org_apache_gluten_memory_NativeMemoryManagerJniWrapper_release
```
DBI destruct stack:
```
0# gluten::GlutenDirectBufferedInput::~GlutenDirectBufferedInput() in
1# gluten::GlutenDirectBufferedInput::~GlutenDirectBufferedInput() in
2# facebook::velox::parquet::ReaderBase::~ReaderBase() in
3# facebook::velox::parquet::ParquetReader::~ParquetReader() in
4# facebook::velox::connector::hive::SplitReader::~SplitReader() in
5# facebook::velox::connector::hive::SplitReader::~SplitReader() in
6# facebook::velox::connector::hive::HiveDataSource::~HiveDataSource() in
7# facebook::velox::connector::hive::HiveDataSource::~HiveDataSource() in
8# facebook::velox::exec::TableScan::~TableScan() in
9# facebook::velox::exec::TableScan::~TableScan() in
10# facebook::velox::exec::Driver::~Driver() in
11# std::__1::__shared_ptr_pointer<facebook::velox::exec::Driver*,
std::__1::shared_ptr<facebook::velox::exec::Driver>::__shared_ptr_default_delete<facebook::velox::exec::Driver,
facebook::velox::exec::Driver>,
std::__1::allocator<facebook::velox::exec::Driver>>::__on_zero_shared() in
12# facebook::velox::exec::Task::next(folly::SemiFuture<folly::Unit>*) in
13# gluten::WholeStageResultIterator::next() in
14# gluten::ResultIterator::hasNext()
15# Java_org_apache_gluten_vectorized_ColumnarBatchOutIterator_nativeHasNext
```
thread:
```
dbi thread id: 0x17670f000
dbi thread id: 0x17670f000
dbi thread id: 0x17670f000
dbi thread id: 0x17670f000
dbi thread id: 0x17670f000
dbi thread id: 0x17670f000
dbi thread id: 0x17670f000
dbi thread id: 0x17670f000
dbi thread id: 0x17670f000
velox memory manager thread id: 0x17670f000
velox memory manager thread id: 0x17670f000
velox memory manager thread id: 0x17670f000
velox memory manager thread id: 0x17670f000
```
They are confirmed in the same thread, and DBI is released before
tryDestrucSafe.
If everything work correctly, we needn't wait in tryDestrucSafe for DBI
release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
