PHILO-HE commented on code in PR #11589:
URL:
https://github.com/apache/incubator-gluten/pull/11589#discussion_r2888481941
##########
.github/workflows/util/install-flink-resources.sh:
##########
@@ -84,18 +91,25 @@ function run_and_time {
}
function install_librdkafka {
- wget_and_untar
https://github.com/confluentinc/librdkafka/archive/refs/tags/${LIBRDKAFKA_VERSION}.tar.gz
librdkafka
+ wget_and_untar
https://github.com/confluentinc/librdkafka/archive/refs/tags/${LIBRDKAFKA_VERSION}.tar.gz
librdkafka tar.gz
cmake_install_dir librdkafka -DBUILD_TESTS=OFF
}
function install_cppkafka {
- wget_and_untar
https://github.com/mfontanini/cppkafka/archive/refs/tags/${CPPKAFKA_VERSION}.tar.gz
cppkafka
+ wget_and_untar
https://github.com/mfontanini/cppkafka/archive/refs/tags/${CPPKAFKA_VERSION}.tar.gz
cppkafka tar.gz
cmake_install_dir cppkafka -DBUILD_TESTS=OFF
}
+function install_rocksdb {
+ wget_and_untar
https://github.com/ververica/frocksdb/archive/refs/heads/FRocksDB-${FROCKSDB_VERSION}.zip
"" zip
Review Comment:
For downloading github repo code, maybe, better to add and use
github_checkout function. Then, keep wget_and_untar unchanged.
https://github.com/facebookincubator/velox/blob/7bc1be16af78637be17ee4950a68b43250c3d44d/scripts/setup-helper-functions.sh#L53
##########
.github/workflows/flink.yml:
##########
@@ -61,8 +61,8 @@ jobs:
sudo dnf install -y patchelf
sudo yum install
https://mirror.stream.centos.org/9-stream/BaseOS/x86_64/os/Packages/tzdata-2025a-1.el9.noarch.rpm
-y
sudo .github/workflows/util/install-flink-resources.sh
- git clone -b gluten-0530 https://github.com/bigo-sg/velox4j.git
- cd velox4j && git reset --hard
288d181a1b05c47f1f17339eb498dd6375f7aec8
+ git clone -b fix_state_init https://github.com/KevinyhZou/velox4j.git
Review Comment:
Recommend to use organization repo. And please also make it consistent with
the commit ID provided in Flink.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
