zhztheplayer commented on code in PR #11657:
URL:
https://github.com/apache/incubator-gluten/pull/11657#discussion_r2889310501
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxMetricsApi.scala:
##########
@@ -628,6 +628,12 @@ class VeloxMetricsApi extends MetricsApi with Logging {
"hashProbeDynamicFiltersProduced" -> SQLMetrics.createMetric(
sparkContext,
"number of hash probe dynamic filters produced"),
+ "valueStreamDynamicFiltersAccepted" -> SQLMetrics.createMetric(
+ sparkContext,
+ "number of dynamic filters accepted by value stream"),
+ "valueStreamDynamicFilteredRows" -> SQLMetrics.createMetric(
+ sparkContext,
+ "number of rows filtered by value stream dynamic filter"),
Review Comment:
Thanks. Would it be possible to move metric `number of dynamic filters
accepted` / `number of rows filtered by value stream dynamic filter:` to
`InputIteratorTransformer`? Which will align with scan filter pushdown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
