JkSelf commented on code in PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#discussion_r2904423895
########## cpp/velox/jni/VeloxJniWrapper.cc: ########## @@ -439,8 +444,8 @@ JNIEXPORT jlong JNICALL Java_org_apache_gluten_utils_VeloxBatchResizerJniWrapper auto ctx = getRuntime(env, wrapper); auto pool = dynamic_cast<VeloxMemoryManager*>(ctx->memoryManager())->getLeafMemoryPool(); auto iter = makeJniColumnarBatchIterator(env, jIter, ctx); - auto appender = std::make_shared<ResultIterator>( - std::make_unique<VeloxBatchResizer>(pool.get(), minOutputBatchSize, maxOutputBatchSize, preferredBatchBytes, std::move(iter))); + auto appender = std::make_shared<ResultIterator>(std::make_unique<VeloxBatchResizer>( Review Comment: Will remove the unnecessary changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
