zhztheplayer commented on code in PR #11728:
URL:
https://github.com/apache/incubator-gluten/pull/11728#discussion_r2905383876
##########
cpp/velox/jni/JniHashTable.h:
##########
@@ -26,13 +26,13 @@
namespace gluten {
-inline static JavaVM* vm = nullptr;
+extern JavaVM* vm;
Review Comment:
nit: Is gluten::vm too wide? Can we possibly wrap the hash table builder in
a wrapper class where the static objects can be stored as members?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
