FelixYBW commented on code in PR #11709:
URL:
https://github.com/apache/incubator-gluten/pull/11709#discussion_r2908833359
##########
cpp/velox/compute/WholeStageResultIterator.cc:
##########
@@ -514,7 +515,8 @@ void WholeStageResultIterator::collectMetrics() {
metrics_->get(Metrics::kPageLoadTime)[metricIndex] =
runtimeMetric("sum", second->customStats, kPageLoadTime);
metrics_->get(Metrics::kDataSourceAddSplitWallNanos)[metricIndex] =
runtimeMetric("sum", second->customStats,
kDataSourceAddSplitWallNanos) +
- runtimeMetric("sum", second->customStats, kWaitForPreloadSplitNanos);
+ runtimeMetric("sum", second->customStats, kWaitForPreloadSplitNanos)
+
+ runtimeMetric("sum", second->customStats,
kPreloadSplitPrepareTimeNanos);
Review Comment:
`kDataSourceAddSplitWallNanos` is used to breakdown the elapsed time of
table scan. It should count the time waiting in main thread only.
`kDataSourceAddSplitWallNanos` count the time when there is no pending split
in queue, we need to start a new split fetch.
`kWaitForPreloadSplitNanos` counts the time when a split is already
prefetched but not returned yet.
`kPreloadSplitPrepareTimeNanos` counts the sum time of all outstanding
prefetched splits time. It doesn't include the ondemand split fetch.
So here
```
metrics_->get(Metrics::kDataSourceAddSplitWallNanos)[metricIndex] =
runtimeMetric("sum", second->customStats,
kDataSourceAddSplitWallNanos) +
runtimeMetric("sum", second->customStats,
kWaitForPreloadSplitNanos)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
