pratham76 commented on PR #11718:
URL:
https://github.com/apache/incubator-gluten/pull/11718#issuecomment-4028110337
Hi @zhztheplayer, Thanks for the clarification, I do get that the proper
solution for the above mentioned TODO would be make spark's error logging more
resilient when CompletionListener crashes.
In this PR, I have tried to refactor the logging logic into separate utility
classes, to handle both scenarios of task failures and task recompute/retries,
just to make the code a bit cleaner. I'm happy to explore the upstream Spark
changes for this TODO (which I have updated here to give better context). For
now, could we proceed with this refactoring as an incremental improvement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
