PHILO-HE commented on PR #11731: URL: https://github.com/apache/incubator-gluten/pull/11731#issuecomment-4028907322
> Hi @PHILO-HE , just thought carefully about your comment in the previous PR: [#11495 (comment)](https://github.com/apache/incubator-gluten/pull/11495#discussion_r2740180164) This time I renamed KnownRowTypeForSpark33OrLater to KnownRowTypeWithDefault, instead of completely merging it with KnownRowType. > > My rationale is "this: SparkPlan =>" created a self-type constraint: If you put this on KnownRowType directly, then any implementor of KnownRowType would have to be a SparkPlan. > > Please correct me if I'm wrong. @QCLyu, the constraint is acceptable maybe. This trait was introduced to categorize Spark Plans based on the data format. So I would advise merging them. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
