jinchengchenghh commented on PR #11729: URL: https://github.com/apache/incubator-gluten/pull/11729#issuecomment-4031012291
Please update here to verify you Velox PR, https://github.com/apache/incubator-gluten/blob/main/ep/build-velox/src/get-velox.sh#L28, and make sure your native implementation is really called. Provide an example test in CI, e.g. warning message disappeared. ``` [main] WARN org.apache.spark.sql.execution.GlutenFallbackReporter - Validation failed for plan: ObjectHashAggregate[QueryId=113], due to: - Validation failed with exception from: RegularHashAggregateExecTransformer, reason: Could not find a valid substrait mapping name for approx_count_distinct_for_intervals(s_store_sk#87088L, org.apache.spark.sql.catalyst.expressions.UnsafeArrayData@3915186b, 0.05, 0, 0). ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
