zhouyuan commented on code in PR #11720:
URL: https://github.com/apache/gluten/pull/11720#discussion_r2912692506
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxValidatorApi.scala:
##########
@@ -104,11 +105,18 @@ class VeloxValidatorApi extends ValidatorApi {
object VeloxValidatorApi {
private def isPrimitiveType(dataType: DataType): Boolean = {
+ val enableTimestampNtzValidation =
VeloxConfig.get.enableTimestampNtzValidation
dataType match {
case BooleanType | ByteType | ShortType | IntegerType | LongType |
FloatType | DoubleType |
StringType | BinaryType | _: DecimalType | DateType | TimestampType |
YearMonthIntervalType.DEFAULT | NullType =>
true
Review Comment:
We should also check this flag in the validator code here
https://github.com/apache/gluten/blob/b88d83a4cc10e8c3392b2af8f1135609ee497178/gluten-substrait/src/main/scala/org/apache/gluten/extension/columnar/validator/Validators.scala#L221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
