This is an automated email from the ASF dual-hosted git repository.
yuanzhou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gluten.git
The following commit(s) were added to refs/heads/main by this push:
new fefdd939ca [GLUTEN-11550][UT] Enable GlutenDataFrameSubquerySuite for
Spark 4.1 (#11727)
fefdd939ca is described below
commit fefdd939ca5e274ab3cd7c478cebc2e886d380a3
Author: Chang Chen <[email protected]>
AuthorDate: Thu Mar 12 01:45:21 2026 +0800
[GLUTEN-11550][UT] Enable GlutenDataFrameSubquerySuite for Spark 4.1
(#11727)
Fix struct join key validation to align with Spark's equalsStructurally
semantics. Remove struct field name comparison in sameType() since
Spark's HashJoin only checks structural type compatibility, not field
names. Also catch exceptions during offload attempt in validation
pipeline to allow graceful fallback.
Co-authored-by: Copilot <[email protected]>
---
.../main/scala/org/apache/gluten/execution/JoinExecTransformer.scala | 1 -
.../test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git
a/gluten-substrait/src/main/scala/org/apache/gluten/execution/JoinExecTransformer.scala
b/gluten-substrait/src/main/scala/org/apache/gluten/execution/JoinExecTransformer.scala
index b4fa188f44..ed98bdc1a5 100644
---
a/gluten-substrait/src/main/scala/org/apache/gluten/execution/JoinExecTransformer.scala
+++
b/gluten-substrait/src/main/scala/org/apache/gluten/execution/JoinExecTransformer.scala
@@ -118,7 +118,6 @@ trait HashJoinLikeExecTransformer extends BaseJoinExec with
TransformSupport {
fromFields.length == toFields.length &&
fromFields.zip(toFields).forall {
case (l, r) =>
- l.name.equalsIgnoreCase(r.name) &&
sameType(l.dataType, r.dataType)
}
diff --git
a/gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
b/gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
index 0dadfa1d0b..2d693bcd9e 100644
---
a/gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
+++
b/gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
@@ -780,7 +780,7 @@ class VeloxTestSettings extends BackendTestSettings {
// Generated suites for org.apache.spark.sql
enableSuite[GlutenCacheManagerSuite]
enableSuite[GlutenDataFrameShowSuite]
- // TODO: 4.x enableSuite[GlutenDataFrameSubquerySuite] // 1 failure
+ enableSuite[GlutenDataFrameSubquerySuite]
enableSuite[GlutenDataFrameTableValuedFunctionsSuite]
enableSuite[GlutenDataFrameTransposeSuite]
enableSuite[GlutenDeprecatedDatasetAggregatorSuite]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
