ReemaAlzaid commented on PR #11615:
URL: https://github.com/apache/gluten/pull/11615#issuecomment-4072169207
> Could you add a unit test like ScalarFunctionsValidateSuite?
I have added the test in `IcebergSuite.scala`
Before:
```
iceberg input_file_name rows: [1,], [2,], [3,]
06:36:46.014 WARN org.apache.spark.rpc.GlutenDriverEndpoint: Execution Id is
11 end.
06:36:46.028 WARN org.apache.spark.rpc.GlutenDriverEndpoint: Execution Id is
12 end.
- iceberg input_file_name *** FAILED ***
scala.Predef.refArrayOps[org.apache.spark.sql.Row](rows).forall(((row:
org.apache.spark.sql.Row) =>
row.isNullAt(1).unary_!.&&(scala.Predef.augmentString(row.getString(1)).nonEmpty)))
was false Expected non-empty input_file_name values, got: [1,], [2,], [3,]
(IcebergSuite.scala:82)
06:36:46.152 WARN org.apache.spark.rpc.GlutenDriverEndpoint: Execution Id is
13 end.
```
After:
```
iceberg input_file_name rows:
[1,file:/Users/reema/Desktop/OpenSource/incubator-gluten/backends-velox/target/scala-2.12/test-classes/tpch-data-iceberg-velox/default/iceberg_input_file_tb/data/00000-4-7e643f49-e402-4f02-8d8a-b051cd5ced2f-0-00001.parquet],
[2,file:/Users/reema/Desktop/OpenSource/incubator-gluten/backends-velox/target/scala-2.12/test-classes/tpch-data-iceberg-velox/default/iceberg_input_file_tb/data/00000-4-7e643f49-e402-4f02-8d8a-b051cd5ced2f-0-00001.parquet],
[3,file:/Users/reema/Desktop/OpenSource/incubator-gluten/backends-velox/target/scala-2.12/test-classes/tpch-data-iceberg-velox/default/iceberg_input_file_tb/data/00000-4-7e643f49-e402-4f02-8d8a-b051cd5ced2f-0-00001.parquet]
06:52:13.430 WARN org.apache.spark.rpc.GlutenDriverEndpoint: Execution Id is
11 end.
06:52:13.438 WARN org.apache.spark.rpc.GlutenDriverEndpoint: Execution Id is
12 end.
- iceberg input_file_name
06:52:13.561 WARN org.apache.spark.rpc.GlutenDriverEndpoint: Execution Id is
13 end
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
