Mariamalmesfer commented on code in PR #11720:
URL: https://github.com/apache/gluten/pull/11720#discussion_r3018354593
##########
gluten-substrait/src/main/scala/org/apache/gluten/extension/columnar/validator/Validators.scala:
##########
@@ -218,8 +231,25 @@ object Validators {
}
}
- private class FallbackByTimestampNTZ() extends Validator {
+ private class FallbackByTimestampNTZ(veloxConf: Option[Any]) extends
Validator {
+ // Check if TimestampNTZ validation is enabled via VeloxConfig
+ private val enableValidation: Boolean = veloxConf match {
+ case Some(config) =>
+ try {
+ val enableMethod =
config.getClass.getMethod("enableTimestampNtzValidation")
+ enableMethod.invoke(config).asInstanceOf[Boolean]
+ } catch {
+ case _: Exception => true
+ }
+ case None => true
+ }
Review Comment:
VeloxConfig isn’t directly accessible from gluten-substrait, so I used
reflection here. I also made a small update to the reflection logic. Please let
me know if you’d prefer a different approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
