jinchengchenghh commented on code in PR #11869:
URL: https://github.com/apache/gluten/pull/11869#discussion_r3027175888
##########
cpp/velox/compute/WholeStageResultIterator.cc:
##########
@@ -358,14 +357,15 @@ void WholeStageResultIterator::constructPartitionColumns(
}
void WholeStageResultIterator::addIteratorSplits(const
std::vector<std::shared_ptr<ResultIterator>>& inputIterators) {
- GLUTEN_CHECK(!allSplitsAdded_, "Method addIteratorSplits should not be
called since all splits has been added to the Velox task.");
+ GLUTEN_CHECK(
Review Comment:
Please remove unrelated changes
##########
cpp/velox/substrait/SubstraitToVeloxPlanValidator.h:
##########
@@ -29,9 +30,15 @@ namespace gluten {
/// a Substrait plan is supported in Velox.
class SubstraitToVeloxPlanValidator {
public:
- SubstraitToVeloxPlanValidator(memory::MemoryPool* pool) {
+ explicit SubstraitToVeloxPlanValidator(
+ memory::MemoryPool* pool,
+ const std::unordered_map<std::string, std::string>& confMap = {}) {
+ const auto it = confMap.find(kSessionTimezone);
+ const auto sessionTimezone =
+ normalizeSessionTimezone(it == confMap.end() ? std::string_view("UTC")
: std::string_view(it->second));
std::unordered_map<std::string, std::string> configs{
- {velox::core::QueryConfig::kSparkPartitionId, "0"},
{velox::core::QueryConfig::kSessionTimezone, "GMT"}};
Review Comment:
update the GMT to other value is enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
