infvg commented on code in PR #11868:
URL: https://github.com/apache/gluten/pull/11868#discussion_r3037461044
##########
cpp/velox/compute/iceberg/IcebergWriter.cc:
##########
@@ -212,7 +221,47 @@ IcebergWriter::IcebergWriter(
}
void IcebergWriter::write(const VeloxColumnarBatch& batch) {
- dataSink_->appendData(batch.getRowVector());
+ auto inputRowVector = batch.getRowVector();
+ auto inputRowType = asRowType(inputRowVector->type());
+
+ // Filter columns to match the expected schema (rowType_)
Review Comment:
We can just splice the columns and remove any additional columns that appear
at the end so we don't have to add any loops
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
