officialasishkumar opened a new pull request, #11905:
URL: https://github.com/apache/gluten/pull/11905

   ## What changes are proposed in this pull request?
   
   Fixes #11885.
   
   `dev/gluten-build-info.sh` was always reading Velox revision metadata from 
the default `ep/build-velox/build/velox_ep` checkout, even when the build used 
a different Velox source tree via `--velox_home`.
   
   This PR updates the build-info path resolution so the Velox revision 
metadata is taken from the actual configured Velox checkout:
   
   - honor an explicit backend path passed to `gluten-build-info.sh`
   - fall back to the exported `VELOX_HOME` environment variable when present
   - fall back to the generated `cpp/build/CMakeCache.txt` `VELOX_HOME` entry 
before using the default path
   - quote the resolved backend path when collecting git metadata
   - export `VELOX_HOME` from `dev/builddeps-veloxbe.sh` so the one-shot Velox 
build flow propagates the configured path into Maven's build-info generation 
step
   - parse `--velox_repo`, `--velox_branch`, and `--velox_home` as scalars so 
`VELOX_HOME` can be exported to child processes correctly
   
   ## How was this patch tested?
   
   - `bash -n dev/gluten-build-info.sh`
   - `bash -n dev/builddeps-veloxbe.sh`
   - created a temporary standalone git repo at `/tmp/fake-velox`
   - verified `VELOX_HOME=/tmp/fake-velox bash dev/gluten-build-info.sh ... 
--backend velox` writes the fake repo commit into `gluten-build-info.properties`
   - verified `source ./dev/builddeps-veloxbe.sh --velox_home=/tmp/fake-velox 
true` exports `VELOX_HOME` for child processes
   
   ## Was this patch authored or co-authored using generative AI tooling?
   
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to