JkSelf commented on code in PR #12009:
URL: https://github.com/apache/gluten/pull/12009#discussion_r3200976212
##########
backends-velox/src/test/scala/org/apache/spark/sql/execution/VeloxExpandSuite.scala:
##########
@@ -77,4 +88,128 @@ class VeloxExpandSuite extends
VeloxWholeStageTransformerSuite {
}
}
}
+
+ test("Expand with round(avg(decimal)) and multiple distinct aggregates") {
Review Comment:
@jianzhenwu Thanks for your fixing.
I tried reproducing the issue in my local environment using the SQL you
provided (https://github.com/apache/gluten/issues/12008#issue-4348749924 and
the two tests here) and the latest main
branch(82644d3ca3f2d93b18b4cfb682656ff3b0111668) with Spark 3.5, but I was
unable to reproduce it.
In Spark, the projection expressions are passed directly from ExpandExec and
should already be aligned with the output schema
https://github.com/apache/spark/blob/c26a127ba33137f36d55bf95cac71471e2a1704f/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala#L1398-L1407.
Could you provide more details on your environment or help investigate why
this occurs on your side?
Thanks for your help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
