marin-ma commented on PR #12097: URL: https://github.com/apache/gluten/pull/12097#issuecomment-4458829783
The payload merging in shuffle reader was removed due to the functionality is duplicated with `VeloxResizeBatchesExec`. It's expected that the merging job should be properly handled by the downstream `VeloxResizeBatchesExec`. Do you see any performance drop after removing the payload merging in shuffle read? > Restore reader-side coalescing for mergeable plain hash shuffle payloads, but flush at Spark shuffle stream boundaries so payloads from different input streams are never combined. Another benefit of using `VeloxResizeBatchesExec` to combine the batches is that it doesn't have the input stream boundary limitation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
