zhli1142015 opened a new pull request, #12101:
URL: https://github.com/apache/gluten/pull/12101
Add a default-enabled VeloxBatchResizer fast path that collects small dense
batches, allocates the output RowVector once, and bulk-copies child vector
ranges with copyRanges. The config remains available as an opt-out switch.
Wire the flag through Scala, Java, and JNI, add C++ coverage for fast-path
and fallback behavior, add config default coverage, and add dense-vector
benchmark scenarios comparing the append opt-out baseline, default copyRanges
path, direct child copyRanges, reader-side raw payload bulk-copy model, and
pre-merged flush model.
Benchmark results from velox_batch_resizer_benchmark (CPU time; ASLR
enabled, so numbers may have noise):
- Mixed_64x64: append opt-out baseline 95.1us, default copyRanges 19.7us,
direct child copyRanges 17.4us, raw bulk-copy model 33.3us.
- Mixed_16x256: append opt-out baseline 33.7us, default copyRanges 6.4us,
direct child copyRanges 5.0us, raw bulk-copy model 10.5us.
- Mixed_256x16: append opt-out baseline 217.7us, default copyRanges 50.4us,
direct child copyRanges 28.6us, raw bulk-copy model 112.6us.
- Fixed2_64x64: append opt-out baseline 26.6us, default copyRanges 5.5us,
direct child copyRanges 2.0us, raw bulk-copy model 13.7us.
- Fixed16_64x64: append opt-out baseline 121.6us, default copyRanges 27.0us,
direct child copyRanges 17.4us, raw bulk-copy model 92.9us.
- LongString_64x64: append opt-out baseline 31.7us, default copyRanges
7.1us, direct child copyRanges 4.5us, raw bulk-copy model 15.3us.
- BoolHeavy_64x64: append opt-out baseline 68.7us, default copyRanges
10.9us, direct child copyRanges 5.4us, raw bulk-copy model 37.7us.
<!--
Thank you for submitting a pull request! Here are some tips:
1. For first-time contributors, please read our contributing guide:
https://github.com/apache/gluten/blob/main/CONTRIBUTING.md
2. If necessary, create a GitHub issue for discussion beforehand to avoid
duplicate work.
3. If the PR is specific to a single backend, include [VL] or [CH] in the PR
title to indicate the
Velox or ClickHouse backend, respectively.
4. If the PR is not ready for review, please mark it as a draft.
-->
## What changes are proposed in this pull request?
<!--
Provide a clear and concise description of the changes introduced in this PR.
Ensure the PR description aligns with the code changes, especially after
updates.
If applicable, include "Fixes #<GitHub_Issue_ID>" to automatically close the
corresponding issue
when the PR is merged.
-->
## How was this patch tested?
<!--
Describe how the changes were tested, if applicable.
Include new tests to validate the functionality, if necessary.
For UI-related changes, attach screenshots to demonstrate the updates.
-->
## Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this
patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
