malinjawi commented on code in PR #12078:
URL: https://github.com/apache/gluten/pull/12078#discussion_r3261145253
##########
backends-velox/pom.xml:
##########
@@ -543,6 +543,32 @@
</dependency>
</dependencies>
</profile>
+ <profile>
+ <id>spark-4.1</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>build-helper-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>add-spark41-delta-test-sources</id>
+ <goals>
+ <goal>add-test-source</goal>
+ </goals>
+ <phase>generate-test-sources</phase>
+ <configuration>
+ <sources>
+
<source>${project.basedir}/src-delta40-spark41/test/scala</source>
+
<source>${project.basedir}/src-delta40-spark41/test/java</source>
Review Comment:
@zhztheplayer
No, Delta 4.0.x targets Spark 4.0.x. For Spark 4.1 this profile uses
`delta-spark_4.1` with `delta.version=4.1.0`.
That said, this `src-delta40-spark41` source-root naming was misleading, so
I removed it. The `MemoryStream` compatibility is now handled in
`shims/spark41`, consistent with the shim-layer pattern for Spark API
differences.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
