jackylee-ch opened a new pull request, #12129:
URL: https://github.com/apache/gluten/pull/12129
## What changes are proposed in this pull request?
`apply_compilation_fixes` in `ep/build-velox/src/get-velox.sh` always
calls `sudo cp` when staging the two Arrow patch files into
`$VELOX_HOME/CMake/resolve_dependency_modules/arrow/`. On macOS the
target directory is user-owned, so the `sudo` triggers an interactive
password prompt on every build with no functional benefit.
Introduce a `SUDO_CMD` variable that resolves to `sudo` on Linux and
an empty string elsewhere; behavior on Linux is unchanged.
## How was this patch tested?
- macOS 14 arm64: `dev/builddeps-veloxbe.sh` no longer prompts for a
password when re-running `apply_compilation_fixes`. The two patch
files land in `$VELOX_HOME/CMake/resolve_dependency_modules/arrow/`
with the user's own ownership.
- Linux x86_64: `SUDO_CMD=sudo`, identical to the previous behavior.
## Was this patch authored or co-authored using generative AI tooling?
co-auth: Claude (Sonnet/Opus) via Claude Code 1.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
