zhztheplayer commented on code in PR #12131: URL: https://github.com/apache/gluten/pull/12131#discussion_r3303987729
########## gluten-delta/src/main/scala/org/apache/gluten/execution/DeltaScanTransformer.scala: ########## @@ -55,16 +67,30 @@ case class DeltaScanTransformer( override lazy val fileFormat: ReadFileFormat = ReadFileFormat.ParquetReadFormat + private lazy val deltaDeletionVectorRegistration + : DeltaScanTransformer.DeletionVectorRegistration = + DeltaScanTransformer.registerDeletionVectorsFromFileFormat(relation) Review Comment: Can we follow the approach in the previous attempt https://github.com/apache/gluten/pull/10740 to pass DVs to native? Would code be simpler that way? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
