malinjawi commented on code in PR #12131:
URL: https://github.com/apache/gluten/pull/12131#discussion_r3312841563
##########
cpp/velox/compute/VeloxPlanConverter.cc:
##########
@@ -75,6 +111,25 @@ std::shared_ptr<SplitInfo> parseScanSplitInfo(
for (const auto& metadataColumn : file.metadata_columns()) {
metadataColumnMap[metadataColumn.key()] = metadataColumn.value();
}
+ for (const auto& otherMetadataColumn :
file.other_const_metadata_columns()) {
+ if (auto unpackedValue =
unpackMetadataValue(otherMetadataColumn.value())) {
Review Comment:
Got it. I extended the Substrait read options with typed Delta DV fields and
stopped carrying this essential Delta metadata through
`other_const_metadata_columns`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
