brijrajk commented on code in PR #12199:
URL: https://github.com/apache/gluten/pull/12199#discussion_r3338881529
##########
backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala:
##########
@@ -66,7 +66,15 @@ class MathFunctionsValidateSuiteAnsiOn extends
FunctionsValidateSuite {
}
}
-abstract class MathFunctionsValidateSuite extends FunctionsValidateSuite {
+class MathFunctionsValidateSuite extends FunctionsValidateSuite {
+
+ // Disable ANSI mode: Spark 4 enables it by default, which wraps math
functions
+ // in ANSI check nodes and prevents ProjectExecTransformer from being the
top-level
+ // plan node. ANSI-specific behaviour is tested in
MathFunctionsValidateSuiteAnsiOn.
+ override protected def sparkConf: SparkConf = {
+ super.sparkConf
+ .set(SQLConf.ANSI_ENABLED.key, "false")
Review Comment:
Oh you are right @philo-he, turns out till this time I was testing it in an
unintended way. Thanks for clearing that up and pointing me to how the ANSI
config is passed — I had only looked at the Maven/Java property passing side
and missed that Spark reads `SPARK_ANSI_SQL_MODE` directly in `SQLConf` to set
the default. I have tested it now with `SPARK_ANSI_SQL_MODE=false` and the
atan2 test passes. Removed the explicit config set in the Scala file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
