marin-ma commented on code in PR #12212:
URL: https://github.com/apache/gluten/pull/12212#discussion_r3340209779
##########
gluten-substrait/src/main/scala/org/apache/gluten/config/GlutenConfig.scala:
##########
@@ -1462,15 +1462,15 @@ object GlutenConfig extends ConfigRegistry {
.booleanConf
.createWithDefault(true)
- val CARTESIAN_PRODUCT_TRANSFORMER_ENABLED =
- buildConf("spark.gluten.sql.cartesianProductTransformerEnabled")
- .doc("Config to enable CartesianProductExecTransformer.")
+ val COLUMNAR_CARTESIAN_PRODUCT_ENABLED =
+ buildConf("spark.gluten.sql.columnar.cartesianProduct")
+ .doc("Enable or disable columnar cartesianProduct.")
.booleanConf
.createWithDefault(true)
- val BROADCAST_NESTED_LOOP_JOIN_TRANSFORMER_ENABLED =
- buildConf("spark.gluten.sql.broadcastNestedLoopJoinTransformerEnabled")
- .doc("Config to enable BroadcastNestedLoopJoinExecTransformer.")
+ val COLUMNAR_BROADCAST_NESTED_LOOP_JOIN_ENABLED =
+ buildConf("spark.gluten.sql.columnar.broadcastNestedLoopJoin")
Review Comment:
We should update the docs along with the configuration naming changes
I noticed that the current names are inconsistent for the operator-level
enablement configurations. Maybe we can unify the naming using a fixed pattern,
such as `spark.gluten.sql.columnar.xxx.enabled`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
