Copilot commented on code in PR #12243:
URL: https://github.com/apache/gluten/pull/12243#discussion_r3358658325
##########
pom.xml:
##########
@@ -1184,6 +1184,7 @@
<delta.package.name>delta-core</delta.package.name>
<delta.version>2.3.0</delta.version>
<delta.binary.version>23</delta.binary.version>
+ <fasterxml.version>2.15.0</fasterxml.version>
Review Comment:
This profile-level property overrides the top-level <fasterxml.version> (now
2.18.6) back to 2.15.0 when building with -Pspark-3.3, which undermines the
stated goal of bumping Jackson to address security warnings and can reintroduce
vulnerable versions in those builds. If there is no strict compatibility
requirement, keep the profile aligned with the bumped version (or remove the
override entirely so it inherits the top-level property).
##########
pom.xml:
##########
@@ -1210,6 +1211,7 @@
<delta.package.name>delta-core</delta.package.name>
<delta.version>2.4.0</delta.version>
<delta.binary.version>24</delta.binary.version>
+ <fasterxml.version>2.15.0</fasterxml.version>
Review Comment:
This profile-level property pins <fasterxml.version> to 2.15.0 for
-Pspark-3.4, overriding the top-level 2.18.6. That means Jackson is not
actually bumped for Spark 3.4 builds, which conflicts with the PR goal of
resolving Jackson security warnings. If compatibility allows, update (or drop)
this override so the security bump applies consistently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
