sezruby commented on PR #12244: URL: https://github.com/apache/gluten/pull/12244#issuecomment-4633245359
> Do we still need to build Arrow Java locally? Mostly no — Maven Central's `arrow-c-data:15.0.0` jar already ships `libarrow_cdata_jni` for `x86_64/` (Linux/macOS/Windows) and `aarch_64/` (Linux/macOS), so x86_64 / aarch64 contributors no longer need the local Java build after this PR. The reason it's still wired into `dev/builddeps-veloxbe.sh` unconditionally: - **ppc64le** has no native in the Central jar. `support_ibm_power.patch` (kept) adds the `ppc64le → ppcle_64` arch case to `JniLoader.java` and the local `mvn install` step bakes a locally-built `libarrow_cdata_jni.so` for ppc64le into the resulting `arrow-c-data:15.0.0` jar in `~/.m2`, overriding Central. Happy to add a follow-up commit gating `build_arrow_java` on `[[ $(uname -m) == ppc64le ]]` so x86_64 / aarch64 users skip ~10 min of redundant work. Holding off in this PR because there's no ppc64le CI lane to confirm the conditional doesn't break the patched build, and I don't have a qemu setup locally to validate it either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
