Copilot commented on code in PR #12252:
URL: https://github.com/apache/gluten/pull/12252#discussion_r3371804719
##########
pom.xml:
##########
@@ -69,7 +69,7 @@
<spark.major.version>3</spark.major.version>
<sparkbundle.version>3.5</sparkbundle.version>
<spark.plain.version>35</spark.plain.version>
- <spark.version>3.5.5</spark.version>
+ <spark.version>4.0.2</spark.version>
<sparkshim.artifactId>spark-sql-columnar-shims-spark35</sparkshim.artifactId>
Review Comment:
`spark.version` is bumped to `4.0.2`, but the surrounding default build
properties are still pinned to the Spark 3.5 toolchain
(`sparkbundle.version=3.5`, `sparkshim.artifactId=...spark35`, and
`scala.binary.version=2.12`). This makes the default build internally
inconsistent: Maven will try to resolve Spark 4.0 artifacts for Scala 2.12 and
compile Gluten modules against the Spark 3.5 shims, which should fail
dependency resolution/compilation. The existing `spark-4.0` / `scala-2.13`
profiles already encode the compatible combination; if Spark 4.0.2 is intended
to be the default, the default properties should be updated accordingly (and
users should build on JDK 17+).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
