Copilot commented on code in PR #12256:
URL: https://github.com/apache/gluten/pull/12256#discussion_r3395308061
##########
gluten-substrait/src/main/scala/org/apache/gluten/extension/columnar/rewrite/RewriteMultiChildrenCount.scala:
##########
@@ -108,6 +147,9 @@ object RewriteMultiChildrenCount extends RewriteSingleNode
with PullOutProjectHe
val newAggExprs = rewriteCount(agg.aggregateExpressions)
copyBaseAggregateExec(agg)(newAggregateExpressions = newAggExprs)
+ case window: WindowExec if shouldRewriteWindow(window.windowExpression)
=>
+ window.copy(windowExpression =
rewriteWindowExpressions(window.windowExpression))
Review Comment:
When rewriting a WindowExec via `window.copy(...)`, the new node does not
inherit SparkPlan tags from the original node (unlike `copyBaseAggregateExec`,
which explicitly calls `copyTagsFrom`). Losing tags can break later
validation/fallback metadata propagation. Copy the tags onto the rewritten
WindowExec before returning it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
