malinjawi commented on code in PR #12269: URL: https://github.com/apache/gluten/pull/12269#discussion_r3395716677
########## cpp/velox/compute/WholeStageResultIterator.cc: ########## @@ -69,6 +73,51 @@ const std::string kWriteIOTime = "writeIOWallNanos"; // others const std::string kHiveDefaultPartition = "__HIVE_DEFAULT_PARTITION__"; +const std::string kDeltaTableFormat = "delta"; +const std::string kTableFormatKey = "table_format"; Review Comment: Good catch, these were actually dead code, nothing on the JVM side ever emits `table_format` metadata, detection is now just the typed `DeltaSplitInfo` from `file_format_case() == kDelta`. Kept the `table_format=delta` entry on the `HiveDeltaSplit` itself though — that's the split-level marker for the connector, same as Iceberg's `hive-iceberg`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
