philo-he commented on code in PR #12261:
URL: https://github.com/apache/gluten/pull/12261#discussion_r3429841307
##########
gluten-substrait/src/main/scala/org/apache/gluten/expression/UnaryExpressionTransformer.scala:
##########
@@ -87,7 +87,7 @@ case class CheckOverflowTransformer(
context,
substraitExprName,
child.doTransform(context),
- original.child.dataType,
+ child.dataType,
Review Comment:
@Xtpacz, thanks for the update. How about adding the test to the
`gluten-ut/test` module to reduce duplicate code if it's independent of any
backend? A new test suite could be created for it. BTW, if some test code
diverges across Spark versions, you might use `testWithSpecifiedSparkVersion`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
