felipepessoto commented on PR #12290: URL: https://github.com/apache/gluten/pull/12290#issuecomment-4739740106
@rui-mo For (`VELOX_USER_CHECK(idx < size)`) -- I have **not** seen Spark produce this, and I don't think a well-formed plan would: the index comes from Spark's resolved `GetStructField.ordinal` / bound attribute ordinals, which the analyzer keeps in range. I added it only as defense-in-depth with a clearer message. In fact, in current Velox `RowType::childAt`/`nameOf` already `VELOX_CHECK_LT(idx, size)`, so an out-of-range index would already throw a catchable `VeloxRuntimeError` and fall back even without this check. I'm dropping that change to keep the PR focused on the real crash fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
