jackylee-ch commented on PR #12211:
URL: https://github.com/apache/gluten/pull/12211#issuecomment-4742766562

   CI is green again after syncing with the latest `main`. Summary of changes 
since the last review round:
   
   - Merged latest `main` and resolved the conflicts (cache-serializer JNI 
binding kept both the new `serializeAll` and the V3 methods; config docs).
   - Fixed undefined behavior in `deserializeWithProjection` for the empty 
(`count(*)`) zero-column projection — `nullptr + 0` when `nCols == 0` 
(addresses the Copilot review comment).
   - Updated the `SPARK-36120 TimestampNTZ` `sizeInBytes` expectation in 
`GlutenCachedTableSuite` (60 → 55) across spark33/34/35/40/41 to match the V3 
per-column cache format. This is the same kind of size-constant update already 
applied to the `testData` test (1132 → 1130); the cached data is unchanged 
(`checkAnswer` still passes). The `TimestampNTZ` test was added upstream after 
this branch was created, so its pre-V3 expected value hadn't been updated.
   
   The earlier `tpc-test-centos8` failure was an unrelated CentOS 8 yum-vault 
infra flake and cleared on the rebuild.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to