Copilot commented on code in PR #12309:
URL: https://github.com/apache/gluten/pull/12309#discussion_r3439175615
##########
backends-clickhouse/src/main/scala/org/apache/gluten/execution/CHBroadcastNestedLoopJoinExecTransformer.scala:
##########
@@ -98,9 +99,9 @@ case class CHBroadcastNestedLoopJoinExecTransformer(
val joinParametersStr = new StringBuffer("JoinParameters:")
joinParametersStr
.append("isBHJ=")
- .append(1)
+ .append(0)
Review Comment:
`isBHJ` is used by the native ClickHouse parser
(`JoinOptimizationInfo::parse`) to set `is_broadcast`, which then gates whether
`BroadcastJoinBuilder::getJoin(...)` is used. Setting `isBHJ=0` for broadcast
nested-loop joins will make `CrossRelParser` skip the storage-join path and
fall back to a non-broadcast join implementation, likely breaking broadcast
join reuse (and potentially correctness checks around column renaming). For
BNLJ this should still be treated as a broadcast join at the
plan/optimization-info level; the BHJ-vs-BNLJ distinction is already conveyed
via `BroadcastJoinContext.isBhj` through the JNI build path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
