Copilot commented on code in PR #12322:
URL: https://github.com/apache/gluten/pull/12322#discussion_r3441158614
##########
dev/docker/Dockerfile.centos9-static-build:
##########
@@ -26,7 +26,8 @@ ENV VCPKG_BINARY_SOURCES=clear;files,${VCPKG_PATH},readwrite
RUN set -ex; \
yum update -y && yum install -y epel-release sudo dnf && yum install -y
ccache; \
- dnf install -y --setopt=install_weak_deps=False gcc-toolset-12
gcc-toolset-13; \
+ dnf install -y --setopt=install_weak_deps=False gcc-toolset-12
gcc-toolset-13 perl-FindBin; \
+ pip install cmake==3.31.4; \
Review Comment:
`pip install` is invoked without explicitly ensuring pip is present in the
image. For reproducible Docker builds (and to avoid base-image changes breaking
the build), install `python3-pip` explicitly and invoke pip via `python3 -m
pip` (also disable pip cache to keep the image smaller).
##########
dev/docker/Dockerfile.centos8-static-build:
##########
@@ -29,6 +29,7 @@ RUN set -ex; \
sed -i -e
"s|#baseurl=http://mirror.centos.org|baseurl=http://vault.centos.org|g"
/etc/yum.repos.d/CentOS-* || true; \
yum update -y && yum install -y epel-release sudo dnf && yum install -y
ccache; \
dnf install -y --setopt=install_weak_deps=False gcc-toolset-11; \
+ pip install cmake==3.31.4; \
Review Comment:
`pip install` is used here but the Dockerfile doesn’t explicitly install
pip. To make the build deterministic across CentOS base-image updates, install
`python3-pip` (and use `python3 -m pip` with `--no-cache-dir`).
##########
dev/docker/Dockerfile.centos8-gcc13-static-build:
##########
@@ -30,7 +30,7 @@ RUN set -ex; \
yum install -y java-1.8.0-openjdk-devel patch git perl python3 automake
libtool flex; \
dnf -y --enablerepo=powertools install autoconf-archive ninja-build; \
pip3 install --upgrade pip; \
- pip3 install cmake; \
+ pip3 install cmake==3.31.4; \
Review Comment:
`pip3 install` will leave a wheel/cache under `~/.cache/pip` unless
disabled/cleaned, which increases the CI image size. Prefer `--no-cache-dir`
for this install.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
