felipepessoto opened a new pull request, #12346: URL: https://github.com/apache/gluten/pull/12346
## What changes are proposed in this pull request? Gluten's `backends-velox/src-delta40/.../test/DeltaSQLCommandTest.scala` is kept as a drop-in, API-compatible copy of Delta's upstream `DeltaSQLCommandTest` trait. The Delta Spark UT pipeline patches this file over Delta's own copy (in a checked-out Delta tree) so that Delta's suites run with the Gluten plugin registered — which means it must expose the same surface as the Delta version it shadows. Delta v4.3.0 - https://github.com/delta-io/delta/commit/247c323b6f4f61d008464a3f60f6cfd0c9ba54a9#diff-aa13085a91889532d3e3d1b9524fc4eb76507823d7c9cd7c322afecd110ac6a2 - added a `checkInvalidBooleanTablePropertyError` helper to that trait, and Delta's own suites now call it: - `DeltaVariantShreddingSuite.scala:212` - `typewidening/TypeWideningTableFeatureSuite.scala:86` Because Gluten's copy overwrites Delta's, the missing helper made those Delta suites fail to compile: ``` not found: value checkInvalidBooleanTablePropertyError (spark / Test / compileIncremental) Compilation failed ``` This PR adds the method (plus the `SparkException` / `SparkThrowable` imports) verbatim from Delta v4.3.0, restoring API parity. The helper accepts either the legacy `_LEGACY_ERROR_TEMP_2045` error class or the newer `UNSUPPORTED_TABLE_CHANGE` class that Spark master now raises, while asserting an unchanged message payload. ## How was this patch tested? - The method and imports are copied verbatim from Delta v4.3.0, so behavior matches upstream exactly. - `SparkThrowable.getErrorClass()` is already used in the sibling `src-delta40/.../DeltaTestUtils.scala`, so the helper compiles under Gluten's own `-Pspark-4.0 -Pscala-2.13` build. - With the helper present, Delta 4.3.0's `DeltaVariantShreddingSuite` and `TypeWideningTableFeatureSuite` compile again in the Delta Spark UT pipeline. ## Was this patch authored or co-authored using generative AI tooling? Generated-by: GitHub Copilot CLI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
