Copilot commented on code in PR #12347: URL: https://github.com/apache/gluten/pull/12347#discussion_r3464128379
########## ep/build-velox/src/get-velox.sh: ########## @@ -18,8 +18,8 @@ set -exu CURRENT_DIR=$(cd "$(dirname "$BASH_SOURCE")"; pwd) VELOX_REPO=https://github.com/IBM/velox.git -VELOX_BRANCH=dft-2026_06_12 -VELOX_ENHANCED_BRANCH=ibm-2026_06_12 +VELOX_BRANCH=staging-rebase-test +VELOX_ENHANCED_BRANCH=staging-rebase-test Review Comment: Hard-coding the default Velox branch to `staging-rebase-test` makes builds non-reproducible and effectively disables the intended `--enable_enhanced_features` behavior (since the enhanced/default branches become identical). This script is used by the standard Velox backend build flow, so the defaults should stay pinned to the stable `dft-*` / `ibm-*` tags (per docs) and developers can still test staging branches via `--velox_branch=`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
