Copilot commented on code in PR #12366:
URL: https://github.com/apache/gluten/pull/12366#discussion_r3475061200
##########
gluten-core/src/main/scala/org/apache/spark/util/SparkShutdownManagerUtil.scala:
##########
@@ -17,12 +17,15 @@
package org.apache.spark.util
object SparkShutdownManagerUtil {
+ private val LIB_UNLOADING_PRIORITY =
ShutdownHookManager.SPARK_CONTEXT_SHUTDOWN_PRIORITY - 1
+ assert(LIB_UNLOADING_PRIORITY >
ShutdownHookManager.TEMP_DIR_SHUTDOWN_PRIORITY)
Review Comment:
The new priority invariant is enforced with `assert` but without a message,
which makes failures hard to diagnose (it would surface as an `AssertionError`
during object initialization). Adding a descriptive assertion message will make
it clearer which Spark priorities were observed when the failure happened.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
