philo-he commented on PR #12368: URL: https://github.com/apache/gluten/pull/12368#issuecomment-4803093394
@infvg, Thanks for the proposal. If I understand correctly, this PR implements a round-robin assignment. My concern is that Gluten has several fairly independent scopes — Velox backend, ClickHouse backend, Flink, Iceberg, Delta, etc. — and reviewing each effectively depends a lot on the reviewer's expertise in that area. A purely round-robin assignment may route a PR to someone outside the relevant scope. For the review process, I'd suggest something like: First, give a short buffer (say ~1 day) for reviewers familiar with the related scope to notice the PR and pick it up. If it's still pending after ~2 days with no reviewer, have someone who knows the community well (e.g. @zhouyuan, or others) assign it to the one or more appropriate reviewers. I also think we should encourage broader participation in reviews — including non-committers, who are very welcome to review. Separately, it seems review turnaround has been slower than before. If that's the case, it might be worth raising it with the community so we can encourage more active reviewing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
