iemejia opened a new pull request, #12389: URL: https://github.com/apache/gluten/pull/12389
## What changes were proposed in this pull request? Fix two minor inefficiencies in `VeloxPlanConverter.cc` (`parseDeltaSplitInfo`): 1. **Double `dynamic_pointer_cast`**: the original code called `dynamic_pointer_cast<DeltaSplitInfo>` twice (once in the ternary condition, once in the true branch). Changed to a single cast + null check. 2. **Unnecessary `std::string` copy from protobuf**: the accessor `serialized_deletion_vector()` returns a `const std::string&` to the internal protobuf field, but `auto` (by value) triggered a full string copy into a local variable. Changed to `const auto&` to bind directly to the protobuf internal field, eliminating the intermediate copy. ## How was this patch tested? - Existing C++ Delta unit tests (19 tests in `velox_delta_read_test`): all pass - `DeltaDeletionVectorScanInfoSuite`: pass - `VeloxDeltaSuite`: pass ## Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude claude-opus-4.6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
