lgbo-ustc commented on code in PR #12327:
URL: https://github.com/apache/gluten/pull/12327#discussion_r3510026124
##########
gluten-flink/runtime/src/main/java/org/apache/gluten/table/runtime/operators/GlutenOneInputOperator.java:
##########
@@ -259,10 +285,18 @@ public void processWatermark2(Watermark mark) throws
Exception {
throw new UnsupportedOperationException("Not implemented for
GlutenOneInputOperator");
}
+ @Override
+ public void endInput() throws Exception {
+ if (inputQueue != null) {
+ inputQueue.noMoreInput();
Review Comment:
`endInput()` now only signals `inputQueue.noMoreInput()`, but the
`finishTask()` method added above is never called in `GlutenOneInputOperator`.
For bounded one-input pipelines, EOF can make the native task produce final
output, so we should drain/finish the task after signalling no more input;
otherwise the last buffered/native output may be dropped before `close()` just
unbinds and closes the task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
