LuciferYang opened a new pull request, #12443: URL: https://github.com/apache/gluten/pull/12443
### What changes were proposed in this pull request? The class-level comment on `OverAcquire` describes a mechanism that stopped existing after #8247. In particular, the comment says `overTarget` "holds the over-acquired memory" and that "once OOM, the over-acquired memory will be used as backup," but `borrow` calls `overTarget.borrow(overSize)` immediately followed by `overTarget.repay(overAcquired)` and asserts `overTarget.usedBytes() == 0` on exit. Nothing is retained. This PR rewrites the class Javadoc and field comments to describe what the code actually does today: a preemptive spill probe. Behavior is unchanged. ### Why are the changes needed? The stale comment misdirects readers debugging OOMs or tuning `spark.gluten.memory.overAcquiredMemoryRatio` — they look for a memory-holding buffer that isn't there. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? `mvn -pl gluten-core -Pspark-3.5 spotless:check` and `compile` pass. Comment-only change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
