marin-ma commented on code in PR #12433:
URL: https://github.com/apache/gluten/pull/12433#discussion_r3520491457
##########
gluten-substrait/src/main/java/org/apache/gluten/substrait/rel/InputIteratorRelNode.java:
##########
@@ -32,13 +40,32 @@ public class InputIteratorRelNode implements RelNode {
private final List<TypeNode> types;
private final List<String> names;
private final Long iteratorIndex;
+ private BigInt rowSize;
Review Comment:
nit: Perhaps rename to `rowCount` as rowSize typically means the size in
bytes of the row.
##########
gluten-substrait/src/main/java/org/apache/gluten/substrait/rel/InputIteratorRelNode.java:
##########
@@ -59,8 +86,21 @@ public Rel toProtobuf() {
LocalFilesBuilder.makeLocalFiles(ConverterUtils.ITERATOR_PREFIX() +
iteratorIndex);
readBuilder.setLocalFiles(iteratorIndexNode.toProtobuf());
+ if (null != rowSize) {
+ Any inputRowSize =
+ Any.pack(StringValue.newBuilder().setValue("rowSize=" +
rowSize.toLong() + "\n").build());
+ AdvancedExtensionNode advancedExtension =
+ ExtensionBuilder.makeAdvancedExtension(inputRowSize, null);
+ readBuilder.setAdvancedExtension(advancedExtension.toProtobuf());
+ }
+
Rel.Builder builder = Rel.newBuilder();
builder.setRead(readBuilder.build());
return builder.build();
}
+
+ @Override
+ public List<RelNode> childNode() {
Review Comment:
nit: `childNodes` or `childNodeList`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
